feat: add S390x support in affinity rule #503
Conversation
Added s390x in node affinity Signed-off-by: Modassar Rana <[email protected]>
Added s390x for node affinity Signed-off-by: Modassar Rana <[email protected]>
oss-prow-bot
bot
requested review from
njhill,
joerunde,
tjohnson31415 and
rafvasq
Signed-off-by: Modassar Rana <[email protected]>
|
/assign @njhill |
There was a problem hiding this comment.
Thanks @modassarrana89, based on the checks it seems like you also need to lint your changes when you get a chance.
Updated comments Signed-off-by: Modassar Rana <[email protected]>
Signed-off-by: Modassar Rana <[email protected]>
|
@rafvasq I have updated the comment & lint the changes on x86. Please review & do the needful |
rafvasq
requested review from
rafvasq
and removed request for
joerunde,
tjohnson31415 and
njhill
rafvasq
changed the title
There was a problem hiding this comment.
Sorry for the delay in returning to this @modassarrana89. It looks like you'll have to lint as before.
Signed-off-by: Christian Kadner <[email protected]>
|
@modassarrana89 -- I updated your branch and fixed the linting issue |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner, modassarrana89, rafvasq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner, modassarrana89, rafvasq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Added s390x in node affinity rule as already work is going on to support s390x for tensorflow in runtime-adaptor